Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1348 - map subprocess stderr to caller stderr #1349

Closed
wants to merge 1 commit into from

Conversation

bwalding
Copy link

No description provided.

@jamesls
Copy link
Member

jamesls commented Jan 15, 2018

Can you share the motivation for this PR? The stderr is included in the exception that's raised, I'm a little hesitant to change this without a good reason.

@jamesls jamesls added response-requested Waiting on additional info and feedback. closing-soon labels Jan 15, 2018
@thatrevguy
Copy link

thatrevguy commented Aug 24, 2018

Hello @jamesls I just tracked this issue down. Not sure about @bwalding but this becomes a problem when credential_process launches an interactive CLI tool. An example would be SAML auth prompting for MFA option.

@lorengordon
Copy link

Linking the issue for the requested info on motivation... #1348

@lorengordon
Copy link

@jamesls Need anything more on this one? It would really help if we could see MFA prompts when using credential_process, and such prompts seem to be often passed through stderr...

@lorengordon
Copy link

@jamesls @JordonPhillips Another use case where stderr getting swallowed makes it much harder to process MFA prompts (particularly when called via credential_process), segmentio/aws-okta#143. Anything we can do to unblock this pr?

@twooster
Copy link

Plus one to this. I just wrote a similar patchset for this before checking the PRs, after spending several hours writing something similar to segment's aws-okta command mentioned above. I would love to see this in the aws cli to simplify MFA workflows.

My patchset checks if stdin/stderr are ttys, and only then pass them through. Would this be an acceptable solution to the maintainers?

@edulop91
Copy link

FWIW AWS libraries in other languages already do this:
https://github.com/aws/aws-sdk-go/blob/master/aws/credentials/processcreds/provider.go#L347

@moritzheiber
Copy link

Can we please merge this PR? This is literally breaking pretty much all of the tooling that needs to request more details before providing credentials. If there's anything that still needs to be done I'm happy to volunteer.

@kdaily kdaily added needs-review This issue or pull request needs review from a core team member. and removed response-requested Waiting on additional info and feedback. closing-soon labels Aug 25, 2021
@bwalding bwalding closed this Nov 22, 2021
@bwalding
Copy link
Author

Closing because this problem doesn't impact me any more (and having it in my dashboard was becoming irksome) - if someone else wants to clone it - please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants